Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update constructors of Stripe exception classes #559

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Update constructors of Stripe exception classes #559

merged 1 commit into from
Aug 22, 2019

Conversation

ob-stripe
Copy link
Contributor

@ob-stripe ob-stripe commented Nov 16, 2018 •
edited
Loading

r? @remi-stripe @brandur-stripe
cc @stripe/api-libraries

@ob-stripe
Copy link
Contributor Author

@remi-stripe Bump! :)

remi-stripe
remi-stripe reviewed Dec 5, 2018
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ob-stripe Sorry, I talked to you about it in private/off PR, and assumed you were also going to re-ping me with more details.

Can you ask someone else to review? I don't understand why you're changing this.

lib/ApiRequestor.php Show resolved Hide resolved
@ob-stripe ob-stripe force-pushed the integration-v7 branch 2 times, most recently from 083bb50 to 3493e70 Compare December 11, 2018 21:35
@ob-stripe ob-stripe mentioned this pull request Dec 11, 2018
Merged
26 tasks
@ob-stripe ob-stripe force-pushed the ob-stripe-error-constructors branch 2 times, most recently from 84dbb9d to e82ab3f Compare December 11, 2018 21:47
@ob-stripe ob-stripe force-pushed the ob-stripe-error-constructors branch from e82ab3f to d459604 Compare December 13, 2018 17:28
@remi-stripe
Copy link
Contributor

@ob-stripe just found this PR, do you know what the next steps are on that one?

@remi-stripe remi-stripe assigned ob-stripe and unassigned remi-stripe Jan 23, 2019
@ob-stripe ob-stripe force-pushed the integration-v7 branch 2 times, most recently from e76eff7 to e573ad2 Compare August 2, 2019 13:54
@ob-stripe ob-stripe force-pushed the ob-stripe-error-constructors branch from d459604 to bbda472 Compare August 2, 2019 13:56
@ob-stripe ob-stripe force-pushed the ob-stripe-error-constructors branch from bbda472 to 1deeecf Compare August 9, 2019 17:11
@ob-stripe ob-stripe force-pushed the integration-v7 branch 2 times, most recently from 843e721 to e2bf05f Compare August 9, 2019 18:49
@ob-stripe ob-stripe force-pushed the ob-stripe-error-constructors branch from 1deeecf to 1b5a773 Compare August 9, 2019 20:46
@ob-stripe ob-stripe force-pushed the ob-stripe-error-constructors branch 2 times, most recently from 22d3727 to 6643899 Compare August 16, 2019 01:02
@ob-stripe
Copy link
Contributor Author

ptal @remi-stripe

I'd like to resume work on stripe-php v7. Once this PR is merged I'll do something similar to stripe/stripe-ruby#811 to allow for accessing the error object from the exception.

@ob-stripe ob-stripe force-pushed the ob-stripe-error-constructors branch from 6643899 to 6169d50 Compare August 20, 2019 20:05
brandur-stripe
brandur-stripe reviewed Aug 21, 2019
View reviewed changes
Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple minor comments, but generally looks good. Thanks for adding the new doc blocks!

ptal @ob-stripe

lib/Error/InvalidRequest.php Outdated Show resolved Hide resolved
lib/Error/OAuth/InvalidClient.php Outdated Show resolved Hide resolved
lib/Error/Base.php Show resolved Hide resolved
@ob-stripe ob-stripe force-pushed the ob-stripe-error-constructors branch from 6169d50 to 3389f30 Compare August 21, 2019 21:33
@ob-stripe
Copy link
Contributor Author

Fixed the comments and explained why the code field needs to be named stripeCode in the class.

@ob-stripe ob-stripe merged commit df226ad into integration-v7 Aug 22, 2019
@ob-stripe ob-stripe deleted the ob-stripe-error-constructors branch August 22, 2019 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandur-stripe brandur-stripe brandur-stripe left review comments

@remi-stripe remi-stripe remi-stripe left review comments

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ob-stripe @remi-stripe @brandur-stripe