Rename fake magic methods and rewrite array conversion #704
+67
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
force-pushed
the
ob-rename-magic-methods
branch
from
45aee3b to
1035004
Compare
brandur-stripe
approved these changes
Aug 22, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries
__toArrayand__toJSONtotoArrayandtoJSON. They weren't actually magic methods so the double underscores were misleading and causing warnings (cf. PHP 7.2 Warnings #587).toArrayto no longer rely onUtil::convertStripeObjectToArray. The implementation is a bit hard to read but it's basically an exact port of the stripe-ruby logic.toArrayno longer accepts a$recursiveargument and always converts recursively.Util::convertStripeObjectToArray. The method was misleading because it pretended to accept aStripeObjectwhen really it expected the$_valuesproperty of aStripeObject. This lead to user confusion (cf. Util::convertToStripeObject and Util::convertStripeObjectToArray don't seem to round-trip #702).Fixes #587, fixes #702.