Rename fake magic methods and rewrite array conversion #704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries
__toArray
and__toJSON
totoArray
andtoJSON
. They weren't actually magic methods so the double underscores were misleading and causing warnings (cf. PHP 7.2 Warnings #587).toArray
to no longer rely onUtil::convertStripeObjectToArray
. The implementation is a bit hard to read but it's basically an exact port of the stripe-ruby logic.toArray
no longer accepts a$recursive
argument and always converts recursively.Util::convertStripeObjectToArray
. The method was misleading because it pretended to accept aStripeObject
when really it expected the$_values
property of aStripeObject
. This lead to user confusion (cf. Util::convertToStripeObject and Util::convertStripeObjectToArray don't seem to round-trip #702).Fixes #587, fixes #702.