Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error messages for nested resource operations #708

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Make the error messages more consistent, recommend the static methods everywhere.

@ob-stripe ob-stripe mentioned this pull request Aug 23, 2019
26 tasks
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, feel free to self approve after fixing

lib/AlipayAccount.php Show resolved Hide resolved
lib/BankAccount.php Show resolved Hide resolved
lib/AlipayAccount.php Show resolved Hide resolved
lib/CustomerBalanceTransaction.php Outdated Show resolved Hide resolved
lib/CustomerBalanceTransaction.php Outdated Show resolved Hide resolved
@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Aug 23, 2019
@ob-stripe ob-stripe force-pushed the ob-nested-error-msgs branch from 24b75ef to 81da9f7 Compare August 23, 2019 00:24
@ob-stripe ob-stripe merged commit 2fb84f0 into integration-v7 Aug 23, 2019
@ob-stripe ob-stripe deleted the ob-nested-error-msgs branch August 23, 2019 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants