Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(CI): replace using metadata-action for the docker push #545

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

qwqcode
Copy link
Member

@qwqcode qwqcode commented Aug 22, 2023

It used to be achieved by complex string concatenation to pass tags to docker/build-push-action.

Now, considering the feature in docker/metadata-action that allows specifying the context to fetch git data, we are reusing the tags generated by metadata-action.

Refer to: docker/metadata-action#248

@qwqcode qwqcode changed the title refactor(CI): replace using docker/metadata-action for the docker push refactor(CI): replace using metadata-action for the docker push Aug 22, 2023
@qwqcode qwqcode merged commit 1e83954 into master Aug 22, 2023
4 checks passed
@qwqcode qwqcode deleted the refactor/CI branch August 22, 2023 08:18
@qwqcode qwqcode restored the refactor/CI branch August 22, 2023 08:19
@qwqcode qwqcode deleted the refactor/CI branch August 22, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant