WIP: Sane default for primary key, fix default value in admin #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this pull request changes, and why. If there is a big design decision(s) involved, put it in the codebase (docstring/README/ADR) and link to it here.
JIRA tickets: If there is a related publicly viewable JIRA ticket, mention that here. Also mention the OSPR ticket number here once it gets created (after you open the PR), if applicable. Otherwise omit this. OpenCraft JIRA ticket numbers should just be put at the beginning of the PR title in square brackets.
Discussions: Link to any past public discussions about this PR or the design/architecture. Otherwise omit this.
Dependencies: None
Screenshots: Always include screenshots if there is any change to the UI (ideally, both "before" and "after" screenshots, if applicable). If there are no UI changes, omit this.
Sandbox URL: TBD - sandbox is being provisioned.
Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.
Testing instructions:
Author notes and concerns:
Reviewers