Add SliderWithCallback component

[mikolajlubiak]

I wanted to do some actions in real time when the slider value changes, not only update the reference value, so I made a little SliderWithCallback component

[mikolajlubiak]

Example usage: https://github.com/mikolajlubiak/memory/

[ArthurSonzogni]

Thanks! This looks like a good thing to have.

Could you please extend the current SliderOption instead? This would avoid duplicating the current code.

[mikolajlubiak]

Hi, done. I wasn't sure whether to initialize callback to empty lambda or nullptr, but nullptr seemed like a better option to me. What do you think?

[mikolajlubiak]

@ArthurSonzogni friendly ping

[ArthurSonzogni]

Thanks! LGTM.

• I renamed callback into on_change.
• I added tests.
• I fixed bugs where on_change was called multiple time per change.
• I added the change to the CHANGELOG.

If anything looks wrong to you, please let me know, and we will maek the appropriate change.

[mikolajlubiak]

Out of curiosity, why use this instead of std::clamp?

[mikolajlubiak]

To get to the contributors list I would have to make more contributions, right?

[mikolajlubiak]

Also would it be cool to add my memory game or media (video/gif/image) into colored, animated or static, ASCII art converter to the projects using FTXUI list or is it for more advanced projects?

[ArthurSonzogni]

To get to the contributors list I would have to make more contributions, right?

You are in the contributor list:

It might take a few hours for the displayed image to be invalidated and the new version to appear.

Also would it be cool to add my memory game or media (video/gif/image) into colored, animated or static, ASCII art converter to the projects using FTXUI list or is it for more advanced projects?

It would be cool. Do you want to submit another PR adding it?

[mikolajlubiak]

Thanks, I made the PR: #946

std::max(this->min(), std::min(this->max(), this->value()));
Out of curiosity, why use this instead of std::clamp?