-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New option on Education projects #213
New option on Education projects #213
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Já vi que está a funcionar como deve :) Consigo ver aqui no teu fork https://github.com/msantosdevlab/ardc-website/blob/inserir-opcao-projetos-educacao-%23205/.github/ISSUE_TEMPLATE/add_new_activity.yaml
Obrigada pela tua contribuição @msantosdevlab !
Vou só taggar a team, para ver se a melhor classificação é escola
ou educação
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ótimo trabalho @msantosdevlab 👏🏾
Obrigada pela tua contribuição 🥳
@@ -108,7 +108,9 @@ function Activities({ translation }) { | |||
</button> | |||
{Object.values(Constants.Categories).map((category, index) => { | |||
const label = category.label; | |||
return ( | |||
const categoryTotal = calculateCategoryTotal(label); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boa correção ✨
Dei conta que no preview a educação tava a mostrar Educação, quando não havia atividades.
Agora está bom! https://ardc-website-git-fork-msantosdevlab-inserir-669e3e-ardc-website.vercel.app/activities
Descrição
Foi inserido a opção "Escola" no select do item "Categoria da atividade".
Fixes #205
Como testar esta modificação?
Checklist: