Merge pull request #27 from AsBuiltReport/dev

v0.4.5 public release
AsBuiltReport · Nov 9, 2023 · 3a3b5ed · 3a3b5ed
2 parents 9ae707d + 15f0562
commit 3a3b5ed
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/AsBuiltReport.VMware.SRM.psd1 b/AsBuiltReport.VMware.SRM.psd1
@@ -12,7 +12,7 @@
 RootModule = 'AsBuiltReport.VMware.SRM.psm1'
 
 # Version number of this module.
-ModuleVersion = '0.4.4'
+ModuleVersion = '0.4.5'
 
 # Supported PSEditions
 # CompatiblePSEditions = @()

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # :arrows_clockwise: VMware SRM As Built Report Changelog
 
+## [0.4.5] - 2023-11-09
+
+### Fixed
+
+- Fix issue where if a protection group was not protecting any VMs, it would list the VMs in the previous protection group in the output. @flynngw
+
 ## [0.4.4] - 2023-08-25
 
 ### Fixed

diff --git a/Src/Private/Get-AbrSRMProtectionGroup.ps1 b/Src/Private/Get-AbrSRMProtectionGroup.ps1
@@ -5,7 +5,7 @@ function Get-AbrSRMProtectionGroup {
     .DESCRIPTION
         Documents the configuration of VMware SRM in Word/HTML/Text formats using PScribo.
     .NOTES
-        Version:        0.4.2
+        Version:        0.4.5
         Author:         Jonathan Colon & Tim Carman
         Twitter:        @jcolonfzenpr / @tpcarman
         Github:         @rebelinux / @tpcarman
@@ -83,6 +83,9 @@ function Get-AbrSRMProtectionGroup {
                                                     if ($ProtectionGroup.ListProtectedVMs()) {
                                                         $ProtectedVMs = ConvertTo-VIobject $ProtectionGroup.ListProtectedVMs().vm.MoRef
                                                     }
+                                                    else {
+                                                        $ProtectedVMs = ""
+                                                    }
 
                                                     $inObj = [ordered] @{
                                                         'Name' = $ProtectionGroupInfo.Name
@@ -117,9 +120,15 @@ function Get-AbrSRMProtectionGroup {
                                                     if ($ProtectionGroup.ListProtectedVMs()) {
                                                         $ProtectedVMs = ConvertTo-VIobject $ProtectionGroup.ListProtectedVMs().vm.MoRef
                                                     }
+                                                    else {
+                                                        $ProtectedVMs = ""
+                                                    }
                                                     if ($ProtectionGroup.ListAssociatedVms()) {
                                                         $AssociatedVMs = ConvertTo-VIobject $ProtectionGroup.ListAssociatedVms().MoRef
                                                     }
+                                                    else {
+                                                        $AssociatedVMs = ""
+                                                    }
 
                                                     $inObj = [ordered] @{
                                                         'Name' = $ProtectionGroupInfo.Name
@@ -161,6 +170,9 @@ function Get-AbrSRMProtectionGroup {
                                                         if ($ProtectionGroup.ListProtectedVMs()) {
                                                             $ProtectedVMs = ConvertTo-VIobject $ProtectionGroup.ListProtectedVMs().vm.MoRef
                                                         }
+                                                        else {
+                                                            $ProtectedVMs = ""
+                                                        }
 
                                                         if ($ProtectionGroup.ListProtectedDatastores()) {
                                                             $ProtectedDatastores = ConvertTo-VIobject $ProtectionGroup.ListProtectedDatastores().MoRef
@@ -197,6 +209,9 @@ function Get-AbrSRMProtectionGroup {
                                                         if ($ProtectionGroup.ListProtectedVMs()) {
                                                             $ProtectedVMs = ConvertTo-VIobject $ProtectionGroup.ListProtectedVMs().vm.MoRef
                                                         }
+                                                        else {
+                                                            $ProtectedVMs = ""
+                                                        }
 
                                                         if ($ProtectionGroup.ListProtectedDatastores()) {
                                                             $ProtectedDatastores = ConvertTo-VIobject $ProtectionGroup.ListProtectedDatastores().MoRef
@@ -248,6 +263,9 @@ function Get-AbrSRMProtectionGroup {
                                                     if ($ProtectionGroup.ListProtectedVMs()) {
                                                         $ProtectedVMs = $ProtectionGroup.ListProtectedVMs()
                                                     }
+                                                    else {
+                                                        $ProtectedVMs = ""
+                                                    }
                                                     if ($InfoLevel.ProtectionGroup -eq 2) {
                                                         foreach ($ProtectedVM in $ProtectedVMs) {
                                                             try {
@@ -349,4 +367,4 @@ function Get-AbrSRMProtectionGroup {
         }
     }
     end {}
-}
+}