Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Commit

Permalink
cpp: do not mention -1 for command_port option
Browse files Browse the repository at this point in the history
-1 is not a valid port number and thus do not mean "no gRPC command server".

If you try to pass -1 to command_port you get:

$ bazel --command_port=-1 build //...
Invalid argument to --command_port: '-1'.
Must be a valid port number or 0.

Change-Id: I6c17167f6a285b21fcd064cea8bdc7e6770ac984
PiperOrigin-RevId: 155352835
  • Loading branch information
tfarina authored and kchodorow committed May 8, 2017
1 parent fefced3 commit 0cf3821
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/main/cpp/startup_options.h
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,7 @@ class StartupOptions {
// empty string if it was not specified on the command line.
std::string GetExplicitHostJavabase() const;

// Port for gRPC command server. 0 means let the kernel choose, -1 means no
// gRPC command server.
// Port to start up the gRPC command server on. If 0, let the kernel choose.
int command_port;

// Connection timeout for each gRPC connection attempt.
Expand Down

0 comments on commit 0cf3821

Please sign in to comment.