Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pagination sample code on the README.mustache template #294

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

jv-asana
Copy link
Contributor

No description provided.

@jv-asana jv-asana requested a review from a team March 22, 2024 22:56
Copy link

@howardtai-asana howardtai-asana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

// EX: print the name of the tasks on that page
console.log(`Page ${pageIndex}: `);
page.data.forEach(task => {
console.log(` ${task.name}`);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that extra tab before task.name intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The extra tab is intentional so that the print statement looks good.

@jv-asana jv-asana merged commit 6f77337 into master Mar 23, 2024
@jv-asana jv-asana deleted the simplify-pagination-sample-code branch March 23, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants