Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated Github Role pattern #299

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

harshita-gupta
Copy link
Member

Uses the new role created in https://github.com/Asana/codez/pull/298254 for publishing the node client library.

Do not merge this PR until https://github.com/Asana/codez/pull/298254 is merged and pushed.

Uses the new role created in Asana/codez#298254 for publishing the node client library.
@harshita-gupta harshita-gupta marked this pull request as draft January 8, 2025 22:04
@harshita-gupta harshita-gupta marked this pull request as ready for review January 8, 2025 22:49
Copy link
Contributor

@jv-asana jv-asana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -83,11 +83,11 @@ jobs:
uses: aws-actions/configure-aws-credentials@v4
with:
aws-region: us-east-1
role-to-assume: arn:aws:iam::403483446840:role/autogen_role_beta_github_actions_release_asana_client_libraries
role-to-assume: arn:aws:iam::403483446840:role/autogen_github_actions_beta_release_asana_node_client_library
- name: Load secrets
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also ran z secret add_roles --name npm_api_key --cluster beta github_actions_release_asana_node_client_library to make sure that the new role has access to the secrets needed!

@harshita-gupta harshita-gupta merged commit 9938bc2 into master Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants