Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags module does not support multi language... (Non ASCII word cannot be saved) #455

Closed
darron1217 opened this issue Jan 15, 2018 · 1 comment
Closed

Tags module does not support multi language... (Non ASCII word cannot be saved) #455

darron1217 opened this issue Jan 15, 2018 · 1 comment

Comments

@darron1217
Copy link
Contributor

darron1217 commented Jan 15, 2018 •
edited
Loading

Summary of issue

Tags module does not support multi language...
Non ASCII word cannot be saved.
Is there a way to use tag without slug?
How about UTF-8 slug? :)

#LetsMakeItBig

Steps to reproduce

ex) Korean Language 태그입니다 cannot be saved because slug is empty field...

Actually, first saving is okay because Tag with empty slug can be inserted into database. But every tag (without ASCII code) gets same empty slug so they override themselves...

System Details

  • Operating System
  • PHP Version
  • Laravel Version
    v5.5.0
  • Asgardcms/Platform version
    v3.4.0
@darron1217 darron1217 mentioned this issue Jan 15, 2018
Merged
nWidart added a commit that referenced this issue Feb 27, 2018
@nWidart
Merge pull request #456 from darron1217/issue#455
d72663e 
Fix for Issue #455 (Adding support for UTF-8 slug)
@nWidart
Copy link
Member

nWidart commented May 26, 2018

Closing since merged.
Thanks! 👍

@nWidart nWidart closed this as completed May 26, 2018
nWidart pushed a commit that referenced this issue Jun 29, 2018
@darron1217 @nWidart
Fix for Issue #455
d5a2323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nWidart @darron1217