Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug that checked the last radio even if wasn't the right one #573

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Fixed a bug that checked the last radio even if wasn't the right one #573

merged 1 commit into from
Aug 24, 2018

Conversation

ChristianGiupponi
Copy link
Contributor

If you create a new module and a settings.php file with the following:

return [
    'default-optimizator' => [
        'description' => 'mediaoptimization::settings.fields.titles.default',
        'view' => 'radio',
        'translatable' => false,
        'options' => [
            'Test' => 'Test',
            'Dummy' => 'Dummy',
        ],
        'default' => 'Dummy',
    ]
];

you can see that if you save the first radio in the DB the value is correct but the view checked the wrong radio, usually the last one.
For some reason the problem was the casting, removing it will work like a charm.

@nWidart
Copy link
Member

nWidart commented Aug 24, 2018

Thank you! 👍

@nWidart nWidart merged commit 84e9191 into AsgardCms:3.0 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants