Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet info): add both HEX and CB58 private key to the template. #89

Merged
merged 2 commits into from
Feb 8, 2024
Merged

feat(wallet info): add both HEX and CB58 private key to the template. #89

merged 2 commits into from
Feb 8, 2024

Conversation

servalD
Copy link
Contributor

@servalD servalD commented Feb 8, 2024

Changes

  • Add HEX and CB58 private keys on the wallet info template.
  • Update the struct and impl of AvalancheWalletInfo.

Nuttymoon
Nuttymoon requested changes Feb 8, 2024
View reviewed changes
crates/ash_cli/src/utils/templating.rs Outdated Show resolved Hide resolved
crates/ash_sdk/src/avalanche/wallets.rs Outdated Show resolved Hide resolved
@servalD @Nuttymoon
feat: apply @Nuttymoon suggestions
86f8cbb 
Co-authored-by: Gauthier Leonard <gauthier@e36knots.com>
@Nuttymoon Nuttymoon merged commit 7af23f0 into main Feb 8, 2024
1 check passed
@Nuttymoon Nuttymoon deleted the enhance-avax-wallet-info branch February 8, 2024 10:43
servalD added a commit that referenced this pull request Feb 9, 2024
@servalD @Nuttymoon
feat(cli): display private key in wallet info (#89)
c9a6941 
Co-authored-by: Gauthier Leonard <gauthier@e36knots.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuttymoon Nuttymoon Nuttymoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@servalD @Nuttymoon