Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete pending validators #94

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Delete pending validators #94

merged 5 commits into from
Apr 19, 2024

Conversation

Al3xGROS
Copy link
Contributor

Changes

  • delete every notion of pending validators
  • fit the need of the new AvalancheGo 1.11.3 version

Additional comments

This is the v0.4.3-rc.1 tag release. When merged, we'll need to update the version of the release to 0.4.3.

Copy link
Contributor

@Nuttymoon Nuttymoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run cargo clippy and fix the issues.

@Al3xGROS
Copy link
Contributor Author

Al3xGROS commented Apr 19, 2024

Run cargo clippy and fix the issues.

I fixed most of the warnings.
However, there should be still one warning when running cargo clippy:

warning: called `unwrap` on `id_from_cb58` after checking its variant with `is_ok`
  --> crates/ash_cli/src/utils/parsing.rs:16:19
   |
15 |     if id_from_cb58.is_ok() {
   |     ----------------------- help: try: `if let Ok(..) = id_from_cb58`
16 |         return Ok(id_from_cb58.unwrap());
   |                   ^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
   = note: `#[warn(clippy::unnecessary_unwrap)]` on by default

But when I try to fix it by following the help indication I get:

warning: redundant pattern matching, consider using `is_ok()`
  --> crates/ash_cli/src/utils/parsing.rs:15:12
   |
15 |     if let Ok(..) = id_from_cb58 {
   |     -------^^^^^^--------------- help: try: `if id_from_cb58.is_ok()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
   = note: `#[warn(clippy::redundant_pattern_matching)]` on by default

It's a warning that also exists on the main branch so do we need to fix it in this PR ?

@Nuttymoon Nuttymoon self-requested a review April 19, 2024 15:13
@Nuttymoon Nuttymoon merged commit a6683e2 into main Apr 19, 2024
1 check passed
@Nuttymoon Nuttymoon deleted the delete-pending-validators branch April 19, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants