Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image zooming feature #545

Closed
wants to merge 1 commit into from
Closed

Image zooming feature #545

wants to merge 1 commit into from

Conversation

nvllz
Copy link
Contributor

@nvllz nvllz commented Jan 19, 2024

As simple as the title.

95a91566-9d41-4e6e-a6d1-2f4c8488728f.mp4

Does not affect scrolling, can be used with multiple gestures. Idk how to make it pan over the image maxSize border, but this way it still seems to be useful in most cases. Based on https://github.com/usuiat/Zoomable.

But... we can only consider this once #502 is merged, as zoomable requires more recent libraries.

@Ashinch
Copy link
Owner

Ashinch commented Jan 19, 2024

Oh, amazing!

Can we take it a step further, like opening a new modal window to display the entire image when clicking on the picture, and additionally providing options for saving?

In version 0.9.12, we need to release the GoogleReader API, and #502 can only be merged into the main branch after that.

@JunkFood02
Copy link
Collaborator

JunkFood02 commented Jan 19, 2024

Shared element transition is not official supported by Compose yet if we want to implement something like Twitter image viewer

https://issuetracker.google.com/issues/202470191

https://github.com/skydoves/Orbital

@nvllz
Copy link
Contributor Author

nvllz commented Jan 20, 2024

Can we take it a step further, like opening a new modal window to display the entire image when clicking on the picture, and additionally providing options for saving?

That's what I had in mind, but I'm probably not capable of making something that complex. I'll try to find another solution, maybe it's not out of my reach.

@Ashinch Ashinch added this to the 0.9.13 milestone Jan 20, 2024
@Ashinch Ashinch changed the base branch from main to dev January 30, 2024 17:32
@Ashinch Ashinch marked this pull request as ready for review January 30, 2024 17:33
@Ashinch
Copy link
Owner

Ashinch commented Jan 30, 2024

But... we can only consider this once #502 is merged, as zoomable requires more recent libraries.

#502 has been merged into the dev branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants