Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse navigation bar into hamburger menu on small screens #152

Closed
psvenk opened this issue Oct 26, 2020 · 1 comment · Fixed by #164
Closed

Collapse navigation bar into hamburger menu on small screens #152

psvenk opened this issue Oct 26, 2020 · 1 comment · Fixed by #164
Labels
enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory)
Milestone

Comments

@psvenk
Copy link
Member

psvenk commented Oct 26, 2020

Continuation of #144 (comment). The tabs on the navigation bar take quite a bit of space on mobile displays, so we should collapse them into a hamburger menu depending on screen size (whether through CSS @media queries or through JavaScript).

Screenshot of the navigation header taking up 4 rows on a 640x1136 mobile screen

IMG_5226

@psvenk psvenk added enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory) labels Oct 26, 2020
@andOrlando
Copy link
Collaborator

andOrlando commented Oct 27, 2020

We should probably rethink what we need there, like if the "gpa type" button is necessary or if the grade/calculated grade even has to be on that bar in the first place.

edit: comment no longer relevant

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants