Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a 404 page #188

Closed
psvenk opened this issue Nov 28, 2020 · 0 comments · Fixed by #190
Closed

Make a 404 page #188

psvenk opened this issue Nov 28, 2020 · 0 comments · Fixed by #190
Labels
enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory)
Milestone

Comments

@psvenk
Copy link
Member

psvenk commented Nov 28, 2020

We should have a proper 404 page for when someone follows a broken link. Implementing this should be as simple as writing the HTML and adding something along the lines of the following to serve.js:

app.use((req, res) => {
  res.status(404);
  res.sendFile("public/404.html");
});
@psvenk psvenk linked a pull request Nov 29, 2020 that will close this issue
@psvenk psvenk added this to the 2.6.0 milestone Nov 29, 2020
@psvenk psvenk added enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory) labels Nov 29, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant