Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build script to show changelog in Aspine Lite #250

Closed
psvenk opened this issue Feb 1, 2021 · 1 comment · Fixed by #271
Closed

Update build script to show changelog in Aspine Lite #250

psvenk opened this issue Feb 1, 2021 · 1 comment · Fixed by #271
Assignees
@psvenk
Labels
enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory)
Milestone
2.7.0

Comments

@psvenk
Copy link
Member

psvenk commented Feb 1, 2021

#240 only shows updates from the changelog in the info tab in live Aspine and not in Aspine Lite (the purely client-side version generated by build-lite.sh). To include this same information in Aspine Lite, we should update the build script so that it renders CHANGELOG.md to HTML and includes it in home.js using the #include pseudo-directive (similarly to how the version number is handled). It may be a good idea to rewrite the build script in Node.js to accomplish this (so that marked can be called directly), which is why I split this off into a separate issue.
@psvenk psvenk added enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory) on hold Will not be worked on until further notice labels Feb 1, 2021
@psvenk psvenk added this to the 2.7.0 milestone Feb 1, 2021
@psvenk
Copy link
Member Author

psvenk commented Feb 6, 2021 •
edited
Loading

We could use preprocessor.js to avoid rolling our own preprocessor and thereby somewhat simplify the build script.

@psvenk psvenk removed the on hold Will not be worked on until further notice label Feb 16, 2021
@psvenk psvenk self-assigned this Feb 17, 2021
@psvenk psvenk mentioned this issue Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psvenk psvenk

Labels
enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory)
Projects
None yet
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

Reimplement build script in JS + show changelog in lite version Aspine/aspine
1 participant
@psvenk