Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve formatting of schedule.json #253

Closed
psvenk opened this issue Feb 6, 2021 · 0 comments · Fixed by #290
Closed

Improve formatting of schedule.json #253

psvenk opened this issue Feb 6, 2021 · 0 comments · Fixed by #290
Assignees
@psvenk
Labels
enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory)
Milestone
2.8.0

Comments

@psvenk
Copy link
Member

psvenk commented Feb 6, 2021

Currently, the start and end times for periods in public/schedule.json are stored in milliseconds since midnight. However, we do not need to store information down to seconds, much less milliseconds. It would be more maintainable to store times as number of minutes since midnight (hour * 60 + minute). Or, even better, we could switch to TOML, which is easier to read and write than JSON and offers native support for dates and times.
@psvenk psvenk added enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory) labels Feb 6, 2021
@psvenk psvenk added this to the 2.8.0 milestone Apr 6, 2021
@psvenk psvenk self-assigned this Apr 7, 2021
@psvenk psvenk mentioned this issue Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psvenk psvenk

Labels
enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory)
Projects
None yet
Milestone
2.8.0
Development

Successfully merging a pull request may close this issue.

Migrate schedule.json to TOML Aspine/aspine
1 participant
@psvenk