Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample JSON file #79

Open
Ruborcalor opened this issue Jan 2, 2020 · 6 comments
Open

Add sample JSON file #79

Ruborcalor opened this issue Jan 2, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory)
Milestone

Comments

@Ruborcalor
Copy link
Member

Add test credentials that allow for one to explore the functionality of Aspine without exposing a real person's username and password / grades.

@psvenk
Copy link
Member

psvenk commented Jan 7, 2020

It might be a good idea to have this implemented as a button (or other UI control) instead of credentials, to avoid a collision with a real username (particularly with #80 implemented) and so that it does not seem as though the credentials are being sent over to the Aspen instance.

@psvenk
Copy link
Member

psvenk commented Mar 23, 2020

Perhaps this could be merged with #74, in that there could be a button on the login page to continue without sending credentials to Aspen, and we could then offer the options of continuing with the test account (a provided JSON export) or uploading one's own JSON export.

@notrodes
Copy link
Collaborator

A username collision cannot happen if the username is a format that is normally invalid for aspen, i.e. "bob".

@notrodes notrodes added the backend Suspected problem with backend (server or scraper) label Mar 27, 2020
@psvenk
Copy link
Member

psvenk commented Mar 27, 2020

A username collision cannot happen if the username is a format that is normally invalid for aspen, i.e. "bob".

The problem with that is that we would be assuming that "bob" is invalid. ICTS could change the username format as they have done in the past. If a teacher's first initial is "B" and last name is "Ob", then "bob" would be a valid username under the current scheme (which may become important for us, if enough teachers are interested in having a teacher adaptation of Aspine).

@psvenk psvenk removed the backend Suspected problem with backend (server or scraper) label Mar 28, 2020
@psvenk
Copy link
Member

psvenk commented Mar 28, 2020

@notrodes This is not necessarily a backend issue, as nothing is being scraped from Aspen.

@psvenk psvenk added enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory) labels Mar 28, 2020
@psvenk psvenk self-assigned this Mar 28, 2020
@psvenk
Copy link
Member

psvenk commented Apr 20, 2020

This can be implemented as a suggested sample JSON file once #74 is merged. I have already begun working on such a file, but it is far from complete.

@psvenk psvenk changed the title Add test account Add sample JSON file Aug 18, 2020
@tektaxi tektaxi added this to the 2.9.1 milestone Oct 6, 2022
@tektaxi tektaxi modified the milestones: 2.9.1, 2.10.0 Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Suspected problem with frontend (client-side code in public directory)
Projects
None yet
Development

No branches or pull requests

4 participants