fix: Fix compiler crash when certain operators used on types #3

src/compiler.ts

@@ -6053,8 +6053,13 @@ export class Compiler extends DiagnosticEmitter {
           ], valueExpression);
         }
       }
+      default: {
+        this.error(
+          DiagnosticCode.The_target_of_an_assignment_must_be_a_variable_or_a_property_access,
+          valueExpression.range
+        );
+      }
     }
-    assert(false);
     return module.unreachable();
   }
 
@@ -9241,9 +9246,6 @@ export class Compiler extends DiagnosticEmitter {
       Constraints.NONE
     );
 
-    // shortcut if compiling the getter already failed
-    if (getExpressionId(getValue) == ExpressionId.Unreachable) return getValue;
-
     // if the value isn't dropped, a temp. local is required to remember the original value,
     // except if a static overload is found, which reverses the use of a temp. (see below)
     var tempLocal: Local | null = null;

tests/compiler/increment-error.json

@@ -0,0 +1,72 @@
+{
+  "asc_flags": [
+  ],
+  "stderr": [
+    "AS234: Expression does not compile to a value at runtime.",
+    "Foo++;",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "Foo++;",
+    "AS234: Expression does not compile to a value at runtime.",
+    "++Foo;",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "++Foo;",
+    "AS234: Expression does not compile to a value at runtime.",
+    "Foo--;",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "Foo--;",
+    "AS234: Expression does not compile to a value at runtime.",
+    "--Foo;",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "--Foo;",
+    "AS234: Expression does not compile to a value at runtime.",
+    "Array++;",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "Array++;",
+    "AS234: Expression does not compile to a value at runtime.",
+    "++Array;",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "++Array;",
+    "AS234: Expression does not compile to a value at runtime.",
+    "Array--;",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "Array--;",
+    "AS234: Expression does not compile to a value at runtime.",
+    "--Array;",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "--Array;",
+    "AS234: Expression does not compile to a value at runtime.",
+    "const a = (Foo++);",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "const a = (Foo++);",
+    "AS234: Expression does not compile to a value at runtime.",
+    "const b = (++Foo);",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "const b = (++Foo);",
+    "AS234: Expression does not compile to a value at runtime.",
+    "const d = (Foo--);",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "const d = (Foo--);",
+    "AS234: Expression does not compile to a value at runtime.",
+    "const e = (--Foo);",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "const e = (--Foo);",
+    "AS234: Expression does not compile to a value at runtime.",
+    "const g = (Array++);",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "const g = (Array++);",
+    "AS234: Expression does not compile to a value at runtime.",
+    "const h = (++Array);",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "const h = (++Array);",
+    "AS234: Expression does not compile to a value at runtime.",
+    "const j = (Array--);",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "const j = (Array--);",
+    "AS234: Expression does not compile to a value at runtime.",
+    "const k = (--Array);",
+    "TS2541: The target of an assignment must be a variable or a property access.",
+    "const k = (--Array);",
+    "AS102: User-defined: \"EOF\"",
+    "ERROR(\"EOF\");"
+  ]
+}

tests/compiler/increment-error.ts

@@ -0,0 +1,38 @@
+/* eslint-disable no-class-assign */
+/* eslint-disable no-global-assign */
+
+class Foo {}
+
+Foo++;
+++Foo;
+// Foo += 1;
+
+Foo--;
+--Foo;
+// Foo -= 1;
+
+Array++;
+++Array;
+// Array += 1;
+
+Array--;
+--Array;
+// Array -= 1;
+
+const a = (Foo++);
+const b = (++Foo);
+// const c = (Foo += 1);
+
+const d = (Foo--);
+const e = (--Foo);
+// const f = (Foo -= 1);
+
+const g = (Array++);
+const h = (++Array);
+// const i = (Array += 1);
+
+const j = (Array--);
+const k = (--Array);
+// const l = (Array -= 1);
+
+ERROR("EOF");