Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support google_json_key_string as an alternative to google_json_key_location #407

Closed
nwallace opened this issue Oct 2, 2020 · 3 comments · Fixed by #415
Closed

Support google_json_key_string as an alternative to google_json_key_location #407

nwallace opened this issue Oct 2, 2020 · 3 comments · Fixed by #415

Comments

@nwallace
Copy link

nwallace commented Oct 2, 2020

In some environments, (in my case, Kubernetes), it can be easier to store uncommitted secrets in the environment itself, rather than on disk. Fog itself supports being configured either way. I don't believe there's a reason this gem can't work the same way
@PikachuEXE
Copy link
Member

Sorry I am on holiday
Come back next week

@PikachuEXE
Copy link
Member

I think it's fine but you have to create the PR and test it (manually)
Automatic test is also required like what's done for GOOGLE_JSON_KEY_LOCATION

RickCSong added a commit to persona-id/asset_sync that referenced this issue Mar 31, 2021
@RickCSong
feat: add support for google_json_key_string
693d72a 
This is requested in
AssetSync#407
@RickCSong RickCSong mentioned this issue Mar 31, 2021
Merged
@PikachuEXE PikachuEXE linked a pull request Mar 31, 2021 that will close this issue
feat: add support for google_json_key_string #415
Merged
@PikachuEXE
Copy link
Member

Should be fixed via #415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for google_json_key_string persona-id/asset_sync
2 participants
@PikachuEXE @nwallace