Fix for @yml being nil #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there's no settings specified for the Rails.env that you are running, @yml will get the value nil. I got that error when running my tests and not specifying any settings for the test environment. The rescue at the ending of line 114 looked a little suspicious, the value incase of an exception would always have been {} and that rescue case would catch all exceptions, making the "rescue Psych::SyntaxError useless." So maybe this solution is more inline with the intention of the writer, if the YAML.load... is nil set it to {}.
|
Sorry, I should merge this eariler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's no settings specified for the Rails.env that you are running, @yml will get the value nil. I got that error when running my tests and not specifying any settings for the test environment.
The rescue at the ending of line 114 in config.rb looked a little suspicious, the value incase of an exception would always have been {} and that rescue case would catch all exceptions, making the "rescue Psych::SyntaxError useless."
So maybe this solution is more inline with the intention of the writer, if the YAML.load... is nil set it to {}.