Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for fog_path_style config option #302

Merged
merged 3 commits into from
Apr 25, 2016
Merged

Support for fog_path_style config option #302

merged 3 commits into from
Apr 25, 2016

Conversation

josacar
Copy link
Contributor

@josacar josacar commented Apr 17, 2015

Support for fog_path_style config option

Review on Reviewable

PikachuEXE
PikachuEXE reviewed Apr 12, 2016
View reviewed changes
spec/unit/asset_sync_spec.rb
@@ -106,6 +111,10 @@
expect(AssetSync.config.fog_region).to eq("eu-west-1")
end

it "should configure path_style" do
AssetSync.config.fog_path_style.should be_truthy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use expect(AssetSync.config.fog_path_style).to be_truthy

@PikachuEXE
Copy link
Member

Please also change README for this new option
Including a link to the doc of path_style in fog
I can't find it :(

@PikachuEXE PikachuEXE mentioned this pull request Apr 12, 2016
Closed
@josacar
Copy link
Contributor Author

josacar commented Apr 21, 2016

Done. Let me know if something else can be improved.

Thanks in advance.

@PikachuEXE
Copy link
Member

In the changed README
It is mentioned that fog_path_style will be included in file generated by the generator
But I am unable to find any change related

To make this PR easier to be merged
I think removing the change about generator is better

@josacar
Copy link
Contributor Author

josacar commented Apr 23, 2016

@PikachuEXE Ups, updated. Just kept the fog optional options

@PikachuEXE PikachuEXE merged commit d9a5921 into AssetSync:master Apr 25, 2016
@PikachuEXE
Copy link
Member

Thanks ;)

@PikachuEXE
Copy link
Member

The new option seems to be AWS only right?
I guess I should move the entry about new option under AWS section

@josacar
Copy link
Contributor Author

josacar commented Apr 25, 2016

AFAIK is fog-aws specific but not sure if it can be applied to another providers.

Thanks.

@dlackty dlackty mentioned this pull request Feb 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josacar @PikachuEXE