Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some AWS options #362

Merged
merged 2 commits into from
Nov 29, 2017
Merged

Add some AWS options #362

merged 2 commits into from
Nov 29, 2017

Conversation

abourquin
Copy link
Contributor

No description provided.

@PikachuEXE
Copy link
Member

Maybe add default value for fog_scheme to doc and comment?
Just like aws_signature_version

@abourquin
Copy link
Contributor Author

It is done ;)

@PikachuEXE PikachuEXE merged commit 8a38fbc into AssetSync:master Nov 29, 2017
@PikachuEXE
Copy link
Member

Thanks :)

@PikachuEXE
Copy link
Member

I found I missed some mistakes and fixed them on master
Can you try to check again and see if anything is missing?
https://github.com/AssetSync/asset_sync/commits/master

One day I will remove the generators and just put example config file on README
Or the other way around
So no one need to update both readme and generator templates when adding new options

@PikachuEXE
Copy link
Member

@abourquin LOL I assumed your reaction means It's ok
Reaction won't send me notification by email btw
Better just reply next time (I just happen to check this thread again)

Will release next week

@PikachuEXE
Copy link
Member

2.3.0 Release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abourquin @PikachuEXE