refactoring get_local_files method #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to use the new method from other gem like |
Closed
PikachuEXE
reviewed
Dec 18, 2017
lib/asset_sync/storage.rb
Outdated
| @@ -58,7 +58,7 @@ def files_to_invalidate | |||
| self.config.invalidate.map { |filename| File.join("/", self.config.assets_prefix, filename) } | |||
| end | |||
|
|
|||
| def get_local_files | |||
| def get_asset_files_from_manifest | |||
There was a problem hiding this comment.
Add a code comment indicating this is a public API for other gem(s)
There was a problem hiding this comment.
Thanks your comment. I did it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just refactoring
get_local_filesmethod.The divided method named
get_asset_files_from_manifestenables to get locale files listed in a manifest file when the manifest exists.