Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ Add option fog_public #377

Merged
merged 1 commit into from
Dec 7, 2018
Merged

+ Add option fog_public #377

merged 1 commit into from
Dec 7, 2018

Conversation

PikachuEXE
Copy link
Member

most code based on #249

Fixes #208

@PikachuEXE
+ Add option fog_public
51e4cc9 
most code based on #249
@PikachuEXE PikachuEXE mentioned this pull request Dec 4, 2018
Closed
@pocari
Copy link
Contributor

pocari commented Dec 4, 2018

LGTM 👍

@coveralls
Copy link

Pull Request Test Coverage Report for Build 290

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 60.634%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/storage.rb 1 60.87%
lib/asset_sync/config.rb 3 91.41%
Totals Coverage Status
Change from base Build 288: 1.06%
Covered Lines: 325
Relevant Lines: 536
💛 - Coveralls

12 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 290

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 60.634%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/storage.rb 1 60.87%
lib/asset_sync/config.rb 3 91.41%
Totals Coverage Status
Change from base Build 288: 1.06%
Covered Lines: 325
Relevant Lines: 536
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 290

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 60.634%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/storage.rb 1 60.87%
lib/asset_sync/config.rb 3 91.41%
Totals Coverage Status
Change from base Build 288: 1.06%
Covered Lines: 325
Relevant Lines: 536
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 290

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 60.634%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/storage.rb 1 60.87%
lib/asset_sync/config.rb 3 91.41%
Totals Coverage Status
Change from base Build 288: 1.06%
Covered Lines: 325
Relevant Lines: 536
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 290

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 60.634%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/storage.rb 1 60.87%
lib/asset_sync/config.rb 3 91.41%
Totals Coverage Status
Change from base Build 288: 1.06%
Covered Lines: 325
Relevant Lines: 536
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 290

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 60.634%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/storage.rb 1 60.87%
lib/asset_sync/config.rb 3 91.41%
Totals Coverage Status
Change from base Build 288: 1.06%
Covered Lines: 325
Relevant Lines: 536
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 290

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 60.634%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/storage.rb 1 60.87%
lib/asset_sync/config.rb 3 91.41%
Totals Coverage Status
Change from base Build 288: 1.06%
Covered Lines: 325
Relevant Lines: 536
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 290

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 60.634%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/storage.rb 1 60.87%
lib/asset_sync/config.rb 3 91.41%
Totals Coverage Status
Change from base Build 288: 1.06%
Covered Lines: 325
Relevant Lines: 536
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 290

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 60.634%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/storage.rb 1 60.87%
lib/asset_sync/config.rb 3 91.41%
Totals Coverage Status
Change from base Build 288: 1.06%
Covered Lines: 325
Relevant Lines: 536
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 290

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 60.634%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/storage.rb 1 60.87%
lib/asset_sync/config.rb 3 91.41%
Totals Coverage Status
Change from base Build 288: 1.06%
Covered Lines: 325
Relevant Lines: 536
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 290

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 60.634%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/storage.rb 1 60.87%
lib/asset_sync/config.rb 3 91.41%
Totals Coverage Status
Change from base Build 288: 1.06%
Covered Lines: 325
Relevant Lines: 536
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 290

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 60.634%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/storage.rb 1 60.87%
lib/asset_sync/config.rb 3 91.41%
Totals Coverage Status
Change from base Build 288: 1.06%
Covered Lines: 325
Relevant Lines: 536
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 290

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.06%) to 60.634%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/storage.rb 1 60.87%
lib/asset_sync/config.rb 3 91.41%
Totals Coverage Status
Change from base Build 288: 1.06%
Covered Lines: 325
Relevant Lines: 536
💛 - Coveralls

@PikachuEXE PikachuEXE merged commit 1aa091d into master Dec 7, 2018
@PikachuEXE PikachuEXE deleted the feature/fog-public branch December 7, 2018 03:21
@PikachuEXE
Copy link
Member Author

2.6.0 Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PikachuEXE @pocari @coveralls