Adds JSON API support when using Google Storage #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Google Storage support requires the use of the S3 compatible API on GCS which is slower and not leveraging service accounts. The underlying library Fog Google does support the ability to use Google Storage JSON API (https://github.com/fog/fog-google#storage) This change adds support for the setting of the relevant config options and passes these config options to Fog Google so that we can use service accounts.
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
15 similar comments
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
Pull Request Test Coverage Report for Build 308
💛 - Coveralls |
|
It would be great to also support 'google_json_key_string', to support environments where you can't store physical files unless you check them into the repo (Heroku) |
|
@reinoutdeclerck - sure happy to add that once this PR lands. |
|
The change looks good for me... |
|
Yes @PikachuEXE we are using this internally at our organisation. |
|
Will release this on Friday or next week |
|
Thanks @PikachuEXE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Google Storage support requires the
use of the S3 compatible API on GCS which is
slower and not leveraging service accounts.
The underlying library Fog Google does support
the ability to use Google Storage JSON API
(https://github.com/fog/fog-google#storage)
This change adds support for the setting of the
relevant config options and passes these config
options to Fog Google so that we can use service
accounts.