Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include fog port in AWS configuration options #385

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Include fog port in AWS configuration options #385

merged 1 commit into from
Jun 6, 2019

Conversation

skuijper
Copy link
Contributor

@skuijper skuijper commented Jun 5, 2019

Fog allows a port to be set for the connection with AWS.

I'm using minio which implements the S3 API, and runs on port 9000. That's where allowing the port to be configured might come in handy.

@coveralls
Copy link

coveralls commented Jun 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 327

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 61.931%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/asset_sync/engine.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 325: 0.1%
Covered Lines: 340
Relevant Lines: 549
💛 - Coveralls

8 similar comments
@coveralls
Copy link

coveralls commented Jun 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 327

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 61.931%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/asset_sync/engine.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 325: 0.1%
Covered Lines: 340
Relevant Lines: 549
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 327

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 61.931%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/asset_sync/engine.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 325: 0.1%
Covered Lines: 340
Relevant Lines: 549
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 327

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 61.931%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/asset_sync/engine.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 325: 0.1%
Covered Lines: 340
Relevant Lines: 549
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 327

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 61.931%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/asset_sync/engine.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 325: 0.1%
Covered Lines: 340
Relevant Lines: 549
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 327

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 61.931%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/asset_sync/engine.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 325: 0.1%
Covered Lines: 340
Relevant Lines: 549
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 327

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 61.931%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/asset_sync/engine.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 325: 0.1%
Covered Lines: 340
Relevant Lines: 549
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 327

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 61.931%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/asset_sync/engine.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 325: 0.1%
Covered Lines: 340
Relevant Lines: 549
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 327

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 61.931%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/asset_sync/engine.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 325: 0.1%
Covered Lines: 340
Relevant Lines: 549
💛 - Coveralls

@PikachuEXE
Copy link
Member

Is the change tested? (Actually run on your project)

@skuijper
Copy link
Contributor Author

skuijper commented Jun 6, 2019

Is the change tested? (Actually run on your project)

I am running this change on my staging environment for a project now.

@PikachuEXE PikachuEXE merged commit 37de00f into AssetSync:master Jun 6, 2019
@PikachuEXE
Copy link
Member

Releasing next week :)

@PikachuEXE
Copy link
Member

Released as 2.8.0
Not sure why I set the todo on today not last Friday 😑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skuijper @coveralls @PikachuEXE