New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use delete_multiple_objects when storage is aws #392

Merged

PikachuEXE merged 1 commit into AssetSync:master from playpasshq:feature/destroy-in-bulk

Dec 27, 2019

Contributor

JanStevens commented Dec 26, 2019

This is an improvement on existing code in MR #352

We now check if the storage is aws? and the connection responds to delete_multiple_objects

The test test the case with aws and delete_multiple_objects and the case without aws and delete_multiple_objects


          Use delete_multiple_objects when storage is aws

0577ad2

coveralls commented Dec 26, 2019 •

edited

Loading

Pull Request Test Coverage Report for Build 369

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.3%) to 64.281%

Totals
Change from base Build 344:	2.3%
Covered Lines:	6504
Relevant Lines:	10118

💛 - Coveralls

coveralls commented Dec 26, 2019

Pull Request Test Coverage Report for Build 369

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.3%) to 64.297%

Totals
Change from base Build 344:	2.3%
Covered Lines:	6150
Relevant Lines:	9565

💛 - Coveralls

coveralls commented Dec 26, 2019 •

edited

Loading

Pull Request Test Coverage Report for Build 369

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.2%) to 64.244%

Totals
Change from base Build 344:	2.2%
Covered Lines:	7566
Relevant Lines:	11777

💛 - Coveralls

PikachuEXE merged commit a1f6ce4 into AssetSync:master

PikachuEXE mentioned this pull request

use a bulk command to delete unneeded files, instead of processing one at time #352

Closed

JanStevens deleted the feature/destroy-in-bulk branch

December 27, 2019 10:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet