Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use threads for uploads #393

Merged
merged 7 commits into from
Jan 15, 2020

Conversation

JanStevens
Copy link
Contributor

Original implementation from #284

Updated based on the comments, for us we saw our CI going from 12min to 3min

By default it's disabled (and using the old logic)

@coveralls
Copy link

coveralls commented Dec 27, 2019

Pull Request Test Coverage Report for Build 381

  • 13 of 14 (92.86%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 64.726%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/asset_sync/engine.rb 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
lib/asset_sync/engine.rb 1 0.0%
Totals Coverage Status
Change from base Build 376: 0.5%
Covered Lines: 8874
Relevant Lines: 13710

💛 - Coveralls

@PikachuEXE
Copy link
Member

Thanks for PR
Can you please update it so that it looks like other boolean config like include_manifest?
YML support and stuff
Also need test case

@JanStevens
Copy link
Contributor Author

Ping small friendly reminder if you got the time :)

@PikachuEXE
Copy link
Member

Oh ya new commits won't trigger a notification on GitHub usually
Anyway will take a look tomorrow or later this week

@PikachuEXE PikachuEXE merged commit 98798a2 into AssetSync:master Jan 15, 2020
@PikachuEXE
Copy link
Member

And released in 2.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants