-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use threads for uploads #393
Merged
PikachuEXE
merged 7 commits into
AssetSync:master
from
playpasshq:feature/threaded-uploads
Jan 15, 2020
Merged
Use threads for uploads #393
PikachuEXE
merged 7 commits into
AssetSync:master
from
playpasshq:feature/threaded-uploads
Jan 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resync Fork
Rebase with master
Pull Request Test Coverage Report for Build 381
💛 - Coveralls |
Thanks for PR |
Ping small friendly reminder if you got the time :) |
Oh ya new commits won't trigger a notification on GitHub usually |
And released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original implementation from #284
Updated based on the comments, for us we saw our CI going from 12min to 3min
By default it's disabled (and using the old logic)