Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AWS temporary credentials #403

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Support AWS temporary credentials #403

merged 1 commit into from
Jun 11, 2020

Conversation

gordonbondon
Copy link
Contributor

When you run asset_sync locally with tools like aws-vault they will get temporary credentials from AWS STS service and set AWS_SESSION_TOKEN

This PR adds support for temporary credentials.

@coveralls
Copy link

coveralls commented Jun 9, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 435

  • 3 of 8 (37.5%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 65.846%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/asset_sync/engine.rb 0 1 0.0%
lib/generators/asset_sync/templates/asset_sync.rb 0 1 0.0%
lib/generators/asset_sync/install_generator.rb 0 3 0.0%
Totals Coverage Status
Change from base Build 419: -0.09%
Covered Lines: 401
Relevant Lines: 609
💛 - Coveralls

PikachuEXE
PikachuEXE requested changes Jun 10, 2020
View reviewed changes
Copy link
Member

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine except please revert the removal of trailing spaces in readme

@gordonbondon
Copy link
Contributor Author

editorconfig was ignored for some reason 😐
Fixed!

@PikachuEXE PikachuEXE merged commit 0dce43e into AssetSync:master Jun 11, 2020
@gordonbondon gordonbondon deleted the sts-credentials branch June 11, 2020 06:26
@PikachuEXE
Copy link
Member

Released in 2.12.0

@gordonbondon
Copy link
Contributor Author

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gordonbondon @coveralls @PikachuEXE