Add Backblaze B2 Cloud Storage

[duartemvix]

This should add support for Backblaze B2 Cloud Storage to Asset Sync

[PikachuEXE]

Have you tested this with actual Backblaze B2?

[duartemvix]

Have you tested this with actual Backblaze B2?

Yes, I did. I'm already using it in my other repositories linkng to my own fork. This one on this PR.

[coveralls]

Pull Request Test Coverage Report for Build 478

• 9 of 35 (25.71%) changed or added relevant lines in 5 files are covered.
• 3 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-2.3%) to 63.509%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/asset_sync/storage.rb	2	3	66.67%
lib/asset_sync/engine.rb	0	3	0.0%
lib/asset_sync/config.rb	7	11	63.64%
lib/generators/asset_sync/templates/asset_sync.rb	0	5	0.0%
lib/generators/asset_sync/install_generator.rb	0	13	0.0%

Files with Coverage Reduction	New Missed Lines	%
lib/asset_sync/config.rb	1	92.15%
lib/asset_sync/engine.rb	1	0%
lib/asset_sync/storage.rb	1	72.63%

Totals
Change from base Build 470:	-2.3%
Covered Lines:	409
Relevant Lines:	644

---

💛 - Coveralls

[PikachuEXE]

There are some failed jobs if you look into Travis
Can you fix it?

[duartemvix]

There are some failed jobs if you look into Travis
Can you fix it?

At Travis, apparently it's failing on old Ruby versions. And as far as I've seen it I'm not sure what is really wrong. I can't seem to understand Coveralls too.

[PikachuEXE]

I think it's due to the double created not stubbing all the method calls

asset_sync/spec/unit/storage_spec.rb

Lines 415 to 442 in cc9d971

	it 'deletes files sequentially' do
	remote_files = ['public/image.png']
	connection = double
	config = double
	directories = double
	directory = double
	file = double
	storage = AssetSync::Storage.new(@config)
	[:local_files, :ignored_files, :always_upload_files].each do |method|
	expect(storage).to receive(method).and_return([])
	end
	allow(storage).to receive(:get_remote_files).and_return(remote_files)
	allow(storage).to receive(:connection).and_return(connection).twice
	allow(storage).to receive(:config).and_return(config)
	allow(config).to receive(:aws?).and_return(false)
	allow(config).to receive(:fog_directory).and_return('foo')
	allow(config).to receive(:assets_prefix).and_return('foo')
	allow(directories).to receive(:get).and_return(directory)
	allow(directory).to receive(:files).and_return([file])
	allow(file).to receive(:key).and_return('public/image.png')
	allow(connection).to receive(:directories).and_return(directories)
	expect(connection).not_to receive(:delete_multiple_objects)
	expect(file).to receive(:destroy)
	storage.delete_extra_remote_files

In this case your updated code calls a new method backblaze? which is not stubbed
Adding a line in that test case like

allow(config).to receive(:backblaze?).and_return(false)

should fix it

[duartemvix]

I think it's due to the double created not stubbing all the method calls

asset_sync/spec/unit/storage_spec.rb

Lines 415 to 442 in cc9d971

	it 'deletes files sequentially' do
	remote_files = ['public/image.png']
	connection = double
	config = double
	directories = double
	directory = double
	file = double
	storage = AssetSync::Storage.new(@config)
	[:local_files, :ignored_files, :always_upload_files].each do |method|
	expect(storage).to receive(method).and_return([])
	end
	allow(storage).to receive(:get_remote_files).and_return(remote_files)
	allow(storage).to receive(:connection).and_return(connection).twice
	allow(storage).to receive(:config).and_return(config)
	allow(config).to receive(:aws?).and_return(false)
	allow(config).to receive(:fog_directory).and_return('foo')
	allow(config).to receive(:assets_prefix).and_return('foo')
	allow(directories).to receive(:get).and_return(directory)
	allow(directory).to receive(:files).and_return([file])
	allow(file).to receive(:key).and_return('public/image.png')
	allow(connection).to receive(:directories).and_return(directories)
	expect(connection).not_to receive(:delete_multiple_objects)
	expect(file).to receive(:destroy)
	storage.delete_extra_remote_files

In this case your updated code calls a new method backblaze? which is not stubbed
Adding a line in that test case like

allow(config).to receive(:backblaze?).and_return(false)

should fix it

I missed that file. You're right, I'll push new changes right about now.

[duartemvix]

@PikachuEXE Have any idea on how to fix jobs that failed running on jruby?

[PikachuEXE]

Don't worry
The "error" is

The job exceeded the maximum time limit for jobs, and has been terminated.

I will just ignore jruby result, probably all passed
And this "error" is probably TravisCI issue

Merging next week otherwise I will forget to release (Too lazy to bring up my Mac on weekend...)

[duartemvix]

Don't worry
The "error" is

The job exceeded the maximum time limit for jobs, and has been terminated.

I will just ignore jruby result, probably all passed
And this "error" is probably TravisCI issue

Merging next week otherwise I will forget to release (Too lazy to bring up my Mac on weekend...)

Oh, okay! Great! Happy to help!

I'm also pushing some changes to the fog/fog-backblaze which in turn will make it more equal to its sisters fog-aws and fog-azurerm. That library needs some updates too but this PR should already make master work at a basic level with Backblaze B2.

[PikachuEXE]

I'm also pushing some changes to the fog/fog-backblaze

I am interested to know more

[PikachuEXE]

Released in 2.13.0