Fix get_non_fingerprinted with dashed filenames #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upload_files uses get_non_fingerprinted to determine if any non-fingerprinted files need to be uploaded because there's a new fingerprinted files. It does this by determining that if assets/image-digest.png needs to be uploaded then assets/image.png should also be uploaded, if it exists. But it faultily would determine that if assets/great-image-digest.png needed to be uploaded then assets/great.png should be uploaded if it exists instead of assets/great-image.png
|
Will try to review this week |
PikachuEXE
reviewed
Feb 25, 2021
lib/asset_sync/storage.rb
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| module AssetSync | |||
| class Storage | |||
| REGEXP_FINGERPRINTED_FILES = /^(.*)\/([^-]+)-[^\.]+\.([^\.]+)$/ | |||
| REGEXP_FINGERPRINTED_FILES = /\A(.*)\/(.+)-[^\.]+\.([^\.]+)\z/ | |||
There was a problem hiding this comment.
Any reason you changed the anchors as well?
There was a problem hiding this comment.
The original anchors only anchored per line and not the whole string. While rare, it is possible to have file names with new lines.
There was a problem hiding this comment.
Is it possible to add a test case for file name with new line then?
There was a problem hiding this comment.
Added. I originally left it out since it's such an extreme edge case, though it did flush out another issue.
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upload_filesusesget_non_fingerprintedto determine if any non-fingerprinted files need to be uploaded because there's a new fingerprinted file. It does this by determining that ifassets/image-digest.pngneeds to be uploaded thenassets/image.pngshould also be uploaded, if it exists. But it faultily would determine that ifassets/great-image-digest.pngneeded to be uploaded thenassets/great.pngshould be uploaded if it exists instead ofassets/great-image.png.