Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop trailing slash of prefix in #get_local_files #425

Merged
merged 2 commits into from
Aug 29, 2024

Commits on Jan 27, 2022

  1. Drop trailing slash of prefix in #get_local_files

    The local filesystem glob in `AssetSync::Storage#get_local_files` uses
    fuzzy matching when config.prefix is present. This can present a problem
    in some cases, as it doesn't allow for distinguishing between (e.g.) a
    folder called `assets/` and another folder called `assets-temp/`. A
    situation could arise where the latter folder has thousands/millions of
    files and we mistakenly publish local-only files, or worse we could
    clobber another directory in the bucket managed in a completely
    different context.
    
    This change allows developers to be more specific in their
    `config.prefix` by using a trailing slash for their folder name.
    alanbrent committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    26c45ed View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Add specs for #get_local_files

    obrie committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    923417f View commit details
    Browse the repository at this point in the history