Fix/broken asset sync prefix #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
approved these changes
Aug 25, 2022
|
Released in |
|
Thank you very much for your fast response!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I am using asset_sync with rails application without sprockets. That means we can't call
Rails.application.config.assets.*, so I wanted to configure theprefixproperty hereasset_sync/lib/asset_sync/config.rb
Line 195 in d0da75d
but noticed that I can't configure
prefixin yaml config.Then I tried to configure it by env but
ASSET_SYNC_PREFIXhad no effect. From my investigation, I believeASSET_SYNC_PREFIXenv is broken from this conflict resolution commit.6547ec7
Fix
ASSET_SYNC_PREFIXenv configuration by moving it insideAssetSync.configureprefixconfiguration feature to yaml config too