Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fog_options to config #431

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Conversation

sunny
Copy link
Contributor

@sunny sunny commented Jan 11, 2023

Closes #430

I went for the more flexible fog_options. It’s more versatile and allows setting (or overriding any fog option). The drawback is that it can’t be set using environment variables.

Copy link
Member

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good enough.
I also think that the comments/doc should mention whatever set in this option will override existing values even they are generated by AssetSync.
What do you think?

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
@sunny
Copy link
Contributor Author

sunny commented Jan 12, 2023

Definitely, thanks for the suggestions!

@PikachuEXE PikachuEXE merged commit 1f69769 into AssetSync:master Jan 13, 2023
@PikachuEXE
Copy link
Member

Released in 2.17.0

@sunny
Copy link
Contributor Author

sunny commented Jan 13, 2023

Awesome! Thank you for maintaining Asset Sync ✨

@sunny sunny deleted the fog-options-config branch January 13, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable fog’s signature v4 streaming
2 participants