Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brotli support #435

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Add brotli support #435

merged 6 commits into from
Aug 9, 2023

Conversation

fengb
Copy link
Contributor

@fengb fengb commented Jul 28, 2023

Brotli has been gaining browser support (96% of users). This adds a flag that enables uploading brotli compressed files in addition to gzip.

There are 2 commits:

  1. add the functionality with minimal rearchitecting
  2. refactor to have a more standardized path for multiple compression schemes

lib/asset_sync/config.rb Outdated Show resolved Hide resolved
lib/asset_sync/engine.rb Outdated Show resolved Hide resolved
@PikachuEXE PikachuEXE merged commit a850d10 into AssetSync:master Aug 9, 2023
19 checks passed
@PikachuEXE
Copy link
Member

I will update the README a bit before releasing

@PikachuEXE
Copy link
Member

I have just updated README in 8550c9d

Please help me review the README to see if there still any outdated/strange places about compression/gzip_compression

alpaca-tc added a commit to alpaca-tc/asset_sync that referenced this pull request Aug 16, 2023
follow-up AssetSync#435

`File.extname(f)` returns '.gz' but `config.compression` is 'gz'
@alpaca-tc alpaca-tc mentioned this pull request Aug 16, 2023
PikachuEXE added a commit that referenced this pull request Aug 16, 2023
follow-up #435

`File.extname(f)` returns '.gz' but `config.compression` is 'gz'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants