Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shiden fee alignment #1071

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Shiden fee alignment #1071

merged 3 commits into from
Oct 31, 2023

Conversation

Dinonard
Copy link
Member

Pull Request Summary

Introduces fee alignment feature into Shiden runtime.

Unlike Shibuya which contains exact params that will be used for Astar (for better testing purposes), Shiden has all fees reduced by a factor of 100x due to having 100 times lesser initial total issuance and block reward.

@Dinonard Dinonard marked this pull request as ready for review October 27, 2023 09:00
@Dinonard Dinonard added shiden related to shiden runtime runtime This PR/Issue is related to the topic “runtime”. labels Oct 27, 2023
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/sr25519/src 79% 0%
chain-extensions/unified-accounts/src 0% 0%
chain-extensions/types/assets/src 0% 0%
chain-extensions/types/unified-accounts/src 0% 0%
precompiles/assets-erc20/src 76% 0%
pallets/ethereum-checked/src 48% 0%
pallets/contracts-migration/src 0% 0%
precompiles/xcm/src 75% 0%
chain-extensions/xvm/src 0% 0%
precompiles/xvm/src 75% 0%
pallets/xc-asset-config/src 53% 0%
precompiles/utils/macro/src 0% 0%
pallets/block-reward/src 85% 0%
chain-extensions/types/dapps-staking/src 0% 0%
precompiles/utils/src/testing 38% 0%
precompiles/utils/src 55% 0%
primitives/src 62% 0%
primitives/src/xcm 66% 0%
pallets/unified-accounts/src 81% 0%
pallets/dynamic-evm-base-fee/src 81% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/dapps-staking/src 81% 0%
pallets/collator-selection/src 69% 0%
chain-extensions/dapps-staking/src 0% 0%
pallets/dapps-staking/src/pallet 85% 0%
precompiles/substrate-ecdsa/src 78% 0%
chain-extensions/pallet-assets/src 0% 0%
pallets/xvm/src 40% 0%
precompiles/dapps-staking/src 93% 0%
Summary 56% (2196 / 3926) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaunxw shaunxw merged commit 34dc2a9 into master Oct 31, 2023
10 of 11 checks passed
@shaunxw shaunxw deleted the feat/shiden-fee-alignment branch October 31, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants