-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/au precompile #1080
Feat/au precompile #1080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor comments in .sol
file
* @title UA interface. | ||
*/ | ||
|
||
/// Interface to the precompiled contract on Shibuya |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better to drop Shibuya
from the comment.
And the address too, I guess. It's not tied to the interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'll drop Shibuya.
For address, it's kind of tied to interface as we have same address in all networks and we have this in every precompile interface, also easier for people to just use it right from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not tied to the .sol
file as an interface.
It's tied to the implementation of this interface in our precompiles - there it's said to be the number mentioned above. But it could just as well change in the implementation without any change being required in the .sol
file.
It's not a big deal, and you are right when you say it's also mentioned in other files.
I consider it to be wrong - however it is convenient.
No need to change it, it was more of a minor comment.
Minimum allowed line rate is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! LGTM
Closes #1055
Pull Request Summary
This PR adds the Precompile for
pallet-unified-account
.Precompile Architecture
the return value of the precompile functions is designed as
(H160/ss58 address,bool)
wherebool
value indicated if the mapping is default or mapped.true
indicates that the mapping exists and precompile is returning the mapped value andfalse
indicates that mapping doesn't exists and the precompile is returning the default value for that address.Check list