Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shiden ethereum get_block_by_number fix #1084

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

Dinonard
Copy link
Member

Pull Request Summary

Update frontier dependencies to include fix for Shiden RPC issue with get_block_by_number.

@Dinonard Dinonard added the client This PR/Issue is related to the topic “client”. label Nov 10, 2023
@Dinonard Dinonard linked an issue Nov 10, 2023 that may be closed by this pull request
Copy link

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/types/unified-accounts/src 0% 0%
pallets/dynamic-evm-base-fee/src 81% 0%
pallets/unified-accounts/src 83% 0%
primitives/src 65% 0%
chain-extensions/dapps-staking/src 0% 0%
precompiles/substrate-ecdsa/src 78% 0%
pallets/dapps-staking/src/pallet 85% 0%
chain-extensions/types/xvm/src 0% 0%
precompiles/utils/macro/src 0% 0%
precompiles/dapps-staking/src 93% 0%
pallets/dapps-staking/src 81% 0%
pallets/contracts-migration/src 0% 0%
chain-extensions/types/dapps-staking/src 0% 0%
pallets/block-reward/src 85% 0%
precompiles/xcm/src 75% 0%
pallets/xc-asset-config/src 53% 0%
precompiles/xvm/src 75% 0%
precompiles/utils/src 55% 0%
pallets/xvm/src 40% 0%
pallets/collator-selection/src 69% 0%
chain-extensions/xvm/src 0% 0%
pallets/ethereum-checked/src 48% 0%
chain-extensions/types/assets/src 0% 0%
primitives/src/xcm 66% 0%
precompiles/utils/src/testing 38% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/assets-erc20/src 77% 0%
precompiles/sr25519/src 79% 0%
chain-extensions/pallet-assets/src 0% 0%
Summary 56% (2214 / 3944) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@PierreOssun PierreOssun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dinonard Dinonard merged commit 1110c86 into master Nov 15, 2023
8 checks passed
@Dinonard Dinonard deleted the fix/shiden-eth-get-block-fix branch November 15, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client This PR/Issue is related to the topic “client”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shiden Earliest Block Query Issue
2 participants