-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dApp Staking v3 improvements #1114
Conversation
/bench shibuya-dev pallet_dapp_staking_migration |
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/7289356746. |
Benchmarks have been finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Minimum allowed line rate is |
Pull Request Summary
Various post-testnet launch improvements.
Maintenance Mode & Migration
Migration doesn't force maintenance mode unless it's really needed. This allows dApp staking v3 to be used before the entire v2 storage has been cleaned up.
Migration Benchmarks
Redid benchmarks for the migration to measure how much is cleaned up in a bulk.
This is useful since the major bottleneck when doing cleanup is the PoV size, which is grossly overestimated
when only one value is cleaned up. Because trie nodes are reused for multiple entries, since they belong to the same pallet, we end up with lesser overestimates if we do bulk benchmarks.
Missing OnRuntimeUpgrade Setting
Added setting of current era info when runtime is upgraded - otherwise it would incorrectly start from zero.
Even if that happens, it's not a breaking bug, but it's incorrect to look at.
Force Calls For Testing
Added two additional root-only calls to be used for dApp staking v3 testing.
They will be removed prior to production network launch.
TODOs