Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update precompile weight #1119

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Conversation

ashutoshvarma
Copy link
Member

Pull Request Summary
fix approve weights for precompile

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • added benchmarks & weights for any modified runtime logics.

@ashutoshvarma ashutoshvarma added the runtime This PR/Issue is related to the topic “runtime”. label Jan 2, 2024
Copy link

github-actions bot commented Jan 2, 2024

Code Coverage

Package Line Rate Branch Rate Health
pallets/dapp-staking-v3/src 78% 0%
chain-extensions/types/assets/src 0% 0%
pallets/dynamic-evm-base-fee/src 81% 0%
primitives/src/xcm 66% 0%
pallets/dapps-staking/src 81% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/collator-selection/src 69% 0%
pallets/xvm/src 40% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/block-rewards-hybrid/src 87% 0%
pallets/dapp-staking-v3/src/test 0% 0%
precompiles/unified-accounts/src 100% 0%
precompiles/sr25519/src 64% 0%
precompiles/dapps-staking/src 94% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/xc-asset-config/src 53% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/dapp-staking-migration/src 39% 0%
precompiles/xcm/src 72% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dapp-staking-v3/src/benchmarking 0% 0%
pallets/dapps-staking/src/pallet 85% 0%
primitives/src 66% 0%
chain-extensions/xvm/src 0% 0%
pallets/unified-accounts/src 84% 0%
precompiles/xvm/src 74% 0%
chain-extensions/types/unified-accounts/src 0% 0%
chain-extensions/pallet-assets/src 0% 0%
pallets/inflation/src 70% 0%
pallets/ethereum-checked/src 48% 0%
precompiles/assets-erc20/src 81% 0%
Summary 67% (3142 / 4658) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashutoshvarma ashutoshvarma merged commit 7be5270 into master Jan 3, 2024
8 of 9 checks passed
@ashutoshvarma ashutoshvarma deleted the feat/precompiles-follow-up branch January 3, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants