dApp Staking v3 - Rewards As Tree #1123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Replaces the sorted vector for rewards, with a
BTreeMap
.This allows for efficient removal of entries from the tree, once reward has been claimed.
Error
DAppRewardAlreadyClaimed
has been removed.Once dApp reward has been claimed for an era, further claim calls will result in
NoClaimableRewards
error.Also includes a minor storage migration, only to be used on Shibuya.
Moved all migration logic under a new module, for better readability.
Benchmarks will be re-run at another time.