Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic static price provider pallet #1125

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Jan 3, 2024

Pull Request Summary

Introduces a basic pallet to handle active native currency price setting.
This is used when calculating dApp tier slots & rewards.

The proper solution will be done in the future via oracle, but for now, a privileged
call for price setting is enabled.

@Dinonard Dinonard added shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Jan 3, 2024
ashutoshvarma
ashutoshvarma previously approved these changes Jan 4, 2024
Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shaunxw
shaunxw previously approved these changes Jan 4, 2024

// You should have received a copy of the GNU General Public License
// along with Astar. If not, see <http://www.gnu.org/licenses/>.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be helpful to have a docstring of pallet descriptions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do it before the merge.

PierreOssun
PierreOssun previously approved these changes Jan 4, 2024
Copy link
Member

@PierreOssun PierreOssun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dinonard Dinonard dismissed stale reviews from PierreOssun, shaunxw, and ashutoshvarma via f719de1 January 5, 2024 11:12
Copy link

github-actions bot commented Jan 5, 2024

Code Coverage

Package Line Rate Branch Rate Health
pallets/xvm/src 40% 0%
pallets/block-rewards-hybrid/src 87% 0%
pallets/dapps-staking/src 81% 0%
pallets/dapp-staking-v3/src/benchmarking 0% 0%
pallets/dapp-staking-migration/src 39% 0%
pallets/inflation/src 70% 0%
pallets/ethereum-checked/src 48% 0%
precompiles/xvm/src 74% 0%
precompiles/assets-erc20/src 81% 0%
primitives/src/xcm 66% 0%
pallets/dapp-staking-v3/src 76% 0%
pallets/dapps-staking/src/pallet 85% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
chain-extensions/types/unified-accounts/src 0% 0%
precompiles/substrate-ecdsa/src 74% 0%
precompiles/unified-accounts/src 100% 0%
pallets/xc-asset-config/src 53% 0%
pallets/dynamic-evm-base-fee/src 81% 0%
chain-extensions/types/xvm/src 0% 0%
chain-extensions/xvm/src 0% 0%
pallets/static-price-provider/src 61% 0%
pallets/unified-accounts/src 84% 0%
precompiles/dapp-staking-v3/src 90% 0%
precompiles/sr25519/src 64% 0%
chain-extensions/pallet-assets/src 0% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
precompiles/xcm/src 72% 0%
pallets/dapp-staking-v3/src/test 0% 0%
chain-extensions/types/assets/src 0% 0%
primitives/src 66% 0%
pallets/collator-selection/src 69% 0%
precompiles/dapps-staking/src 94% 0%
Summary 67% (3182 / 4733) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard merged commit 0cba858 into master Jan 5, 2024
8 checks passed
@Dinonard Dinonard deleted the feat/static-price-provider branch January 5, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants