Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded DappStakingApi #1126

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Expanded DappStakingApi #1126

merged 3 commits into from
Jan 8, 2024

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Jan 4, 2024

Pull Request Summary

Extends the dApp staking runtime API with two additional calls:

  • periods_per_cycle() - how many periods occur in a single inflation cycle
  • get_dapp_tier_assignment() - returns dApps tier assignment based on the staked values at the called block

@Dinonard Dinonard added shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Jan 4, 2024
@Dinonard Dinonard marked this pull request as ready for review January 5, 2024 13:57
Copy link

github-actions bot commented Jan 5, 2024

Code Coverage

Package Line Rate Branch Rate Health
precompiles/dapps-staking/src 94% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
precompiles/xcm/src 72% 0%
precompiles/assets-erc20/src 81% 0%
pallets/dapps-staking/src/pallet 85% 0%
pallets/dynamic-evm-base-fee/src 81% 0%
pallets/xvm/src 40% 0%
pallets/collator-selection/src 69% 0%
pallets/dapp-staking-v3/src 76% 0%
chain-extensions/pallet-assets/src 0% 0%
precompiles/dapp-staking-v3/src 90% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/dapp-staking-v3/src/benchmarking 0% 0%
precompiles/unified-accounts/src 100% 0%
pallets/static-price-provider/src 61% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/inflation/src 70% 0%
chain-extensions/xvm/src 0% 0%
chain-extensions/types/unified-accounts/src 0% 0%
primitives/src 66% 0%
primitives/src/xcm 66% 0%
pallets/ethereum-checked/src 48% 0%
chain-extensions/types/xvm/src 0% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/xc-asset-config/src 53% 0%
precompiles/xvm/src 74% 0%
pallets/dapp-staking-migration/src 39% 0%
pallets/unified-accounts/src 84% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/dapps-staking/src 81% 0%
pallets/block-rewards-hybrid/src 87% 0%
precompiles/sr25519/src 64% 0%
chain-extensions/types/assets/src 0% 0%
Summary 67% (3182 / 4739) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@shaunxw shaunxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dinonard Dinonard merged commit 21acad9 into master Jan 8, 2024
10 checks passed
@Dinonard Dinonard deleted the feat/dapp-staking-v3-improvements branch January 8, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants