dApp Staking v3 - improvements & fixes #1128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Various fixes & minor improvements as the result of retro-review, testing, etc.
Minor Changes
reward_destination
field intoreward_beneficiary
Incorrect
staked
andstaked_future
It was possible for the
stake
operation to incorrectly manipulatestaked
andstaked_future
valuesin the
AccountLedger
struct. As a result, staker could increase the stake of their historical era, incorrectly.This has been fixed by ensuring proper move operation from
staked_future
over tostaked
.