Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp Staking v3 - improvements & fixes #1128

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Jan 8, 2024

Summary

Various fixes & minor improvements as the result of retro-review, testing, etc.

Minor Changes

  • rename precompile unit tests
  • lots of typo fixes
  • apply retro review suggestions
  • rename reward_destination field into reward_beneficiary

Incorrect staked and staked_future

It was possible for the stake operation to incorrectly manipulate staked and staked_future values
in the AccountLedger struct. As a result, staker could increase the stake of their historical era, incorrectly.

This has been fixed by ensuring proper move operation from staked_future over to staked.

@Dinonard Dinonard added the runtime This PR/Issue is related to the topic “runtime”. label Jan 8, 2024
@Dinonard Dinonard marked this pull request as ready for review January 15, 2024 06:58
@Dinonard Dinonard requested review from PierreOssun, ashutoshvarma and shaunxw and removed request for PierreOssun January 15, 2024 06:58
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/dapp-staking-v3/src/benchmarking 0% 0%
pallets/dapps-staking/src/pallet 85% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/unified-accounts/src 84% 0%
precompiles/xvm/src 74% 0%
precompiles/dapps-staking/src 94% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/dynamic-evm-base-fee/src 81% 0%
pallets/xc-asset-config/src 53% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/static-price-provider/src 61% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
precompiles/dapp-staking-v3/src 90% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/collator-selection/src 69% 0%
precompiles/assets-erc20/src 81% 0%
chain-extensions/types/unified-accounts/src 0% 0%
precompiles/unified-accounts/src 100% 0%
precompiles/sr25519/src 64% 0%
chain-extensions/types/assets/src 0% 0%
precompiles/xcm/src 72% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dapps-staking/src 81% 0%
pallets/block-rewards-hybrid/src 87% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/inflation/src 70% 0%
pallets/dapp-staking-migration/src 39% 0%
pallets/dapp-staking-v3/src 76% 0%
pallets/ethereum-checked/src 48% 0%
pallets/xvm/src 40% 0%
primitives/src/xcm 66% 0%
primitives/src 66% 0%
chain-extensions/xvm/src 0% 0%
Summary 70% (3249 / 4623) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dinonard Dinonard merged commit 5c6d6f0 into master Jan 15, 2024
11 checks passed
@Dinonard Dinonard deleted the feat/dsv3-retro-review branch January 15, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants