Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockdrop Precompile Fix #1208

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Lockdrop Precompile Fix #1208

merged 6 commits into from
Mar 27, 2024

Conversation

PierreOssun
Copy link
Member

Pull Request Summary

Restricted the call bytes args to a 4096 bytes max length. I think this size is permissive enough to cover all extrinsic calls.
Collators have a heap size of 131Mb so it is also conservative enough.

@PierreOssun PierreOssun added the runtime This PR/Issue is related to the topic “runtime”. label Mar 27, 2024
@PierreOssun PierreOssun requested a review from Dinonard March 27, 2024 14:02
Dinonard
Dinonard previously approved these changes Mar 27, 2024
@@ -57,6 +57,8 @@ pub struct DispatchLockdrop<Runtime, DispatchValidator, DecodeLimit = ConstU32<8
PhantomData<(Runtime, DispatchValidator, DecodeLimit)>,
);

type CallLengthLimit = ConstU32<{ 2u32.pow(12) }>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick comment - perhaps it's just me, but I'd find 4 * 1024 more readable 🙃

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So maybe 4096 directly then

Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/dapp-staking-migration/src 0% 0%
pallets/ethereum-checked/src 79% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/dapps-staking/src 89% 0%
pallets/xc-asset-config/src 64% 0%
pallets/block-rewards-hybrid/src 91% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/inflation/src 83% 0%
precompiles/substrate-ecdsa/src 74% 0%
primitives/src/xcm 65% 0%
pallets/dapp-staking-v3/src/benchmarking 99% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/static-price-provider/src 58% 0%
precompiles/dapps-staking/src 93% 0%
pallets/collator-selection/src 91% 0%
precompiles/dapp-staking-v3/src 90% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/xvm/src 74% 0%
precompiles/assets-erc20/src 81% 0%
pallets/astar-xcm-benchmarks/src 87% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
precompiles/xcm/src 73% 0%
primitives/src 29% 0%
pallets/dapp-staking-v3/src 91% 0%
pallets/dapp-staking-v3/src/test 0% 0%
chain-extensions/pallet-assets/src 56% 0%
precompiles/dispatch-lockdrop/src 86% 0%
primitives/src/migrations 0% 0%
chain-extensions/types/assets/src 0% 0%
pallets/xvm/src 51% 0%
pallets/dapps-staking/src/pallet 86% 0%
pallets/unified-accounts/src 85% 0%
precompiles/sr25519/src 64% 0%
chain-extensions/xvm/src 0% 0%
precompiles/unified-accounts/src 100% 0%
Summary 76% (4305 / 5687) 0% (0 / 0)

Minimum allowed line rate is 50%

@PierreOssun PierreOssun merged commit 3003bce into master Mar 27, 2024
8 checks passed
@PierreOssun PierreOssun deleted the fix/lockdrop-audit branch March 27, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants