Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow xtoken in dispatch precompile #1216

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

ashutoshvarma
Copy link
Member

Pull Request Summary
Whitelist the following calls for dispatch precompile

  • orml_xtokens::transfer_multiasset_with_fee
  • orml_xtokens::transfer_multiasset

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • added benchmarks & weights for any modified runtime logics.

@ashutoshvarma ashutoshvarma added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Code Coverage

Package Line Rate Branch Rate Health
pallets/dapp-staking-migration/src 0% 0%
pallets/dapp-staking-v3/src 91% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/dapp-staking-v3/src/benchmarking 99% 0%
pallets/dapp-staking-v3/src/test 0% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
precompiles/unified-accounts/src 100% 0%
precompiles/dapps-staking/src 93% 0%
pallets/dapps-staking/src 89% 0%
precompiles/xcm/src 73% 0%
precompiles/dapp-staking-v3/src 90% 0%
chain-extensions/types/unified-accounts/src 0% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/oracle-benchmarks/src 0% 0%
pallets/price-aggregator/src 72% 0%
precompiles/sr25519/src 64% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/xvm/src 51% 0%
chain-extensions/pallet-assets/src 56% 0%
chain-extensions/xvm/src 0% 0%
pallets/unified-accounts/src 85% 0%
primitives/src/xcm 65% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
chain-extensions/types/assets/src 0% 0%
pallets/inflation/src 83% 0%
pallets/dapps-staking/src/pallet 86% 0%
precompiles/assets-erc20/src 81% 0%
primitives/src/migrations 0% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
pallets/ethereum-checked/src 79% 0%
pallets/astar-xcm-benchmarks/src 87% 0%
pallets/static-price-provider/src 52% 0%
precompiles/xvm/src 74% 0%
primitives/src 29% 0%
pallets/block-rewards-hybrid/src 91% 0%
pallets/collator-selection/src 91% 0%
pallets/xc-asset-config/src 64% 0%
Summary 76% (4416 / 5845) 0% (0 / 0)

Minimum allowed line rate is 50%

@ashutoshvarma ashutoshvarma merged commit a8520ab into master Apr 3, 2024
11 of 12 checks passed
@ashutoshvarma ashutoshvarma deleted the feat/dispatch-xtokens branch April 3, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants